Pin all apollo deps via renovate config #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwillson
reviewed
Jan 31, 2019
abernix
added a commit
that referenced
this pull request
Mar 8, 2019
This follows up on @trevor-sheer's #951, which switched to exact pinning for all deps in the `apollo` CLI. As the #951 PR body notes, we want exactly that for `apollo`, however using the `rangeStrategy` of `pin` also includes renovation of the `engines` setting in `package.json`, which we don't want and resulted in #1078 which also exact-pinned `engines` for `node` and `npm`. (screenshot as it will change after this PR: https://c.jro.cc/ac9256ebf6ae). That PR didn't and won't land, but it's currently immortal and we want it to go away. It's existence, as it makes clear in the PR body, is defined by configuration though. Specifically, the default Renovate configuration on this repository uses the `renovate-config-apollo-open-source` defaults. i.e.: https://github.com/apollographql/renovate-config-apollo-open-source/blob/master/package.json That default specifies we extend `:pinOnlyDevDependencies`: https://github.com/apollographql/renovate-config-apollo-open-source/blob/master/package.json#L14 And that `:pinOnlyDevDependencies` is defined as: https://renovatebot.com/docs/presets-default/#pinonlydevdependencies This changes to the more appropriate `:pinAllExceptPeerDependencies`: https://renovatebot.com/docs/presets-default/#pinallexceptpeerdependencies ...which excludes `engines`.
abernix
added a commit
that referenced
this pull request
Mar 8, 2019
This follows up on @trevor-sheer's #951, which switched to exact pinning for all deps in the `apollo` CLI. As the #951 PR body notes, we want exactly that for `apollo`, however using the `rangeStrategy` of `pin` also includes renovation of the `engines` setting in `package.json`, which we don't want and resulted in #1078 which also exact-pinned `engines` for `node` and `npm`. (screenshot as it will change after this PR: https://c.jro.cc/ac9256ebf6ae). I think @trevor-sheer tried to fix this with #889 and #1069, but I believe this would be the more complete solution to that configuration. The #951 which prompted this commit message didn't and won't land, but it's currently immortal and we want it to go away. It's existence, as it makes clear in the PR body, is defined by configuration though. Specifically, the default Renovate configuration on this repository uses the `renovate-config-apollo-open-source` defaults. i.e.: https://github.com/apollographql/renovate-config-apollo-open-source/blob/master/package.json That default specifies we extend `:pinOnlyDevDependencies`: https://github.com/apollographql/renovate-config-apollo-open-source/blob/master/package.json#L14 And that `:pinOnlyDevDependencies` is defined as: https://renovatebot.com/docs/presets-default/#pinonlydevdependencies This changes to the more appropriate `:pinAllExceptPeerDependencies`: https://renovatebot.com/docs/presets-default/#pinallexceptpeerdependencies ...which excludes `engines`.
abernix
added a commit
that referenced
this pull request
Mar 8, 2019
This follows up on @trevor-sheer's #951, which switched to exact pinning for all deps in the `apollo` CLI. As the #951 PR body notes, we want exactly that for `apollo`, however using the `rangeStrategy` of `pin` also includes renovation of the `engines` setting in `package.json`, which we don't want and resulted in #1078 which also exact-pinned `engines` for `node` and `npm`. (screenshot as it will change after this PR: https://c.jro.cc/ac9256ebf6ae). I think @trevor-sheer tried to fix this with #889 and #1069, but I believe this would be the more complete solution to that configuration. The #951 which prompted this commit message didn't and won't land, but it's currently immortal and we want it to go away. It's existence, as it makes clear in the PR body, is defined by configuration though. Specifically, the default Renovate configuration on this repository uses the `renovate-config-apollo-open-source` defaults. i.e.: https://github.com/apollographql/renovate-config-apollo-open-source/blob/master/package.json That default specifies we extend `:pinOnlyDevDependencies`: https://github.com/apollographql/renovate-config-apollo-open-source/blob/master/package.json#L14 And that `:pinOnlyDevDependencies` is defined as: https://renovatebot.com/docs/presets-default/#pinonlydevdependencies This changes to the more appropriate `:pinAllExceptPeerDependencies`: https://renovatebot.com/docs/presets-default/#pinallexceptpeerdependencies ...which excludes `engines`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on recent experience with packages breaking underneath us, and the typical inherent usage of the CLI being via
npx, we should pin all deps for theapollopackage.For reference, see example 3 in the link below. This decision is also recommended by renovate for our case:
https://renovatebot.com/docs/dependency-pinning/#so-whats-best