Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strip leading empty lines in flow generated code #1127

Merged
merged 4 commits into from
Mar 19, 2019
Merged

Strip leading empty lines in flow generated code #1127

merged 4 commits into from
Mar 19, 2019

Conversation

ganemone
Copy link
Contributor

@ganemone ganemone commented Mar 18, 2019 •
edited
Loading

This updates apollo-codegen-flow to strip leading empty lines in flow generated code. This is required to ensure the generated code passes lint, since eslint will only be disabled for all the code after the /* eslint-disable */ comment.

  • Update CHANGELOG.md* with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

trevor-scheer
trevor-scheer approved these changes Mar 19, 2019
View reviewed changes
Copy link
Member

@trevor-scheer trevor-scheer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ganemone! 🎉

@trevor-scheer trevor-scheer merged commit e878c9c into apollographql:master Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trevor-scheer trevor-scheer trevor-scheer approved these changes

@jbaxleyiii jbaxleyiii Awaiting requested review from jbaxleyiii

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ganemone @trevor-scheer