Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add environment-aware createHash function to apollo-env #1110

Merged
merged 3 commits into from
Mar 13, 2019

Conversation

trevor-scheer
Copy link
Member

This is a subset of changes proposed by this PR:
#1027

This PR adds a createHash function to apollo-env which is environment aware. That is to say, it will work in both node-like and non-node environments.

This PR also uses this function from within the apollo-graphql package.

TODO:

  • Update CHANGELOG.md* with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.

Add environment awareness in order to use crypto/sha.js when appropriate
Copy link
Member

@abernix abernix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@trevor-scheer trevor-scheer merged commit 190fabd into master Mar 13, 2019
@trevor-scheer trevor-scheer deleted the trevor/apollo-env-createHash branch March 13, 2019 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants