Only widen the semver range for the graphql dependency of apollo.
#1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per the correct assessment of what we want from the `graphql` package within the `apollo` package, in the following conversation: #1078 (comment) Specifically, we're okay using whatever 14.x version of `graphql` is potentially already available to us when someone installs `apollo` into their application's `devDependencies` in an existing application. If the existing application doesn't already have a 14.x version of `graphql` we will use the latest `14.x` version. With any success, this will cl_ose #1078 automatically (and not just because I said "close PR number" in this commit message!).
1 task
|
@trevor-scheer Worked! #1078 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the correct assessment of what we want from the
graphqlpackage withinthe
apollopackage, in the following conversation:#1078 (comment)
Specifically, we're okay using whatever 14.x version of
graphqlispotentially already available to us when someone installs
apollointotheir application's
devDependenciesin an existing application.If the existing application doesn't already have a 14.x version of
graphqlwe will use the latest
14.xversion.With any success, this will cl_ose #1078 automatically (and not just because
I said "close PR number" in this commit message!).