Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the default --tag flag from client commands #1062

Merged
merged 4 commits into from
Mar 4, 2019
Merged

Remove the default --tag flag from client commands #1062

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a54c178
remove the default --tag from client commands
JakeDawkins Feb 28, 2019
e5756eb
remove flag override for check since its in the default set
JakeDawkins Feb 28, 2019
6a83a71
update changelog
JakeDawkins Feb 28, 2019
1e7e944
update types with correct types from master tag
JakeDawkins Feb 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

- `apollo`
- Use generated Typescript types via client:codegen [#1016](https://github.com/apollographql/apollo-tooling/pull/1016)
- Remove default `--tag=current` for some client commands that used it [#1062](https://github.com/apollographql/apollo-tooling/pull/1062)

# `apollo@2.5.3`

Expand Down
9 changes: 3 additions & 6 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 2 additions & 5 deletions packages/apollo-language-server/src/graphqlTypes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
export interface CheckSchema_service_checkSchema_diffToPrevious_changes {
__typename: "Change";
/**
* Indication of the success of the change, either failure, warning, or notice.
* Indication of the success of the overall change, either failure, warning, or notice.
*/
type: ChangeType;
/**
Expand Down Expand Up @@ -39,10 +39,7 @@ export interface CheckSchema_service_checkSchema_diffToPrevious_validationConfig

export interface CheckSchema_service_checkSchema_diffToPrevious {
__typename: "SchemaDiff";
/**
* Indication of the most frequently occurring ChangeType in the list of changes from this diff.
*/
type: ChangeType | null;
type: ChangeType;
changes: CheckSchema_service_checkSchema_diffToPrevious_changes[];
validationConfig: CheckSchema_service_checkSchema_diffToPrevious_validationConfig | null;
}
Expand Down
3 changes: 1 addition & 2 deletions packages/apollo/src/Command.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,8 +243,7 @@ export abstract class ClientCommand extends ProjectCommand {
}),
tag: flags.string({
char: "t",
description: "The published service tag for this client",
default: "current"
description: "The published service tag for this client"
}),
queries: flags.string({
description: "Deprecated in favor of the includes flag"
Expand Down
6 changes: 1 addition & 5 deletions packages/apollo/src/commands/client/check.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,7 @@ interface LocationOffset {
export default class ClientCheck extends ClientCommand {
static description = "Check a client project against a pushed service";
static flags = {
...ClientCommand.flags,
tag: flags.string({
char: "t",
description: "The published tag to check this client against"
})
...ClientCommand.flags
};

async run() {
Expand Down
2 changes: 0 additions & 2 deletions packages/apollo/src/commands/client/extract.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,6 @@ export default class ClientExtract extends ClientCommand {
static flags = {
...ClientCommand.flags
};
// not a public feature for now
// static hidden = true;

static args = [
{
Expand Down