Remove the default --tag flag from client commands (#1062)

* remove the default --tag from client commands
apollographql · Mar 4, 2019 · 80a715d · 80a715d
1 parent e608ba7
commit 80a715d
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 20 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,7 @@
 
 - `apollo`
   - Use generated Typescript types via client:codegen [#1016](https://github.com/apollographql/apollo-tooling/pull/1016)
+  - Remove default `--tag=current` for some client commands that used it [#1062](https://github.com/apollographql/apollo-tooling/pull/1062)
 
 # `apollo@2.5.3`
 

diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/apollo-language-server/src/graphqlTypes.ts b/packages/apollo-language-server/src/graphqlTypes.ts
@@ -9,7 +9,7 @@
 export interface CheckSchema_service_checkSchema_diffToPrevious_changes {
   __typename: "Change";
   /**
-   * Indication of the success of the change, either failure, warning, or notice.
+   * Indication of the success of the overall change, either failure, warning, or notice.
    */
   type: ChangeType;
   /**
@@ -39,10 +39,7 @@ export interface CheckSchema_service_checkSchema_diffToPrevious_validationConfig
 
 export interface CheckSchema_service_checkSchema_diffToPrevious {
   __typename: "SchemaDiff";
-  /**
-   * Indication of the most frequently occurring ChangeType in the list of changes from this diff.
-   */
-  type: ChangeType | null;
+  type: ChangeType;
   changes: CheckSchema_service_checkSchema_diffToPrevious_changes[];
   validationConfig: CheckSchema_service_checkSchema_diffToPrevious_validationConfig | null;
 }

diff --git a/packages/apollo/src/Command.ts b/packages/apollo/src/Command.ts
@@ -243,8 +243,7 @@ export abstract class ClientCommand extends ProjectCommand {
     }),
     tag: flags.string({
       char: "t",
-      description: "The published service tag for this client",
-      default: "current"
+      description: "The published service tag for this client"
     }),
     queries: flags.string({
       description: "Deprecated in favor of the includes flag"

diff --git a/packages/apollo/src/commands/client/check.ts b/packages/apollo/src/commands/client/check.ts
@@ -24,11 +24,7 @@ interface LocationOffset {
 export default class ClientCheck extends ClientCommand {
   static description = "Check a client project against a pushed service";
   static flags = {
-    ...ClientCommand.flags,
-    tag: flags.string({
-      char: "t",
-      description: "The published tag to check this client against"
-    })
+    ...ClientCommand.flags
   };
 
   async run() {

diff --git a/packages/apollo/src/commands/client/extract.ts b/packages/apollo/src/commands/client/extract.ts
@@ -27,8 +27,6 @@ export default class ClientExtract extends ClientCommand {
   static flags = {
     ...ClientCommand.flags
   };
-  // not a public feature for now
-  // static hidden = true;
 
   static args = [
     {