Don't swallow errors from Engine (#705)

* Don't swallow errors from Engine Throw errors we receive from Engine so we can provide the right feedback to users and handle the errors. * error.message is already a string, don't interpolate Fixes #701
apollographql · Nov 14, 2018 · 809c027 · 809c027
1 parent 8169dc1
commit 809c027
Showing 1 changed file with 12 additions and 12 deletions.
diff --git a/packages/apollo-language-server/src/engine/index.ts b/packages/apollo-language-server/src/engine/index.ts
@@ -130,9 +130,9 @@ export class ApolloEngineClient extends GraphQLDataSource {
         );
       }
       // use error logger
-      // if (errors) {
-      //   throw new Error(errors);
-      // }
+      if (errors) {
+        throw new Error(errors.map(error => error.message).join("\n"));
+      }
       if (!data) {
         throw new Error("Error in request from Engine");
       }
@@ -151,9 +151,9 @@ export class ApolloEngineClient extends GraphQLDataSource {
         );
       }
       // use error logger
-      // if (errors) {
-      //   throw new Error(errors);
-      // }
+      if (errors) {
+        throw new Error(errors.map(error => error.message).join("\n"));
+      }
       if (!data) {
         throw new Error("Error in request from Engine");
       }
@@ -170,9 +170,9 @@ export class ApolloEngineClient extends GraphQLDataSource {
           );
         }
         // use error logger
-        // if (errors) {
-        //   throw new Error(errors);
-        // }
+        if (errors) {
+          throw new Error(errors.map(error => error.message).join("\n"));
+        }
         if (!data) {
           throw new Error("Error in request from Engine");
         }
@@ -190,9 +190,9 @@ export class ApolloEngineClient extends GraphQLDataSource {
           );
         }
         // use error logger
-        // if (errors) {
-        //   throw new Error(errors);
-        // }
+        if (errors) {
+          throw new Error(errors.map(error => error.message).join("\n"));
+        }
         if (!data) {
           throw new Error("Error in request from Engine");
         }