Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set response body to actually send JSON back #823

Closed
wants to merge 2 commits into from
Closed

set response body to actually send JSON back #823

wants to merge 2 commits into from

Conversation

antstanley
Copy link

Content-Type set to 'application/json', but a string is being sent back. Update to send back a JSON object.

TODO:

  • Update CHANGELOG.md with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

antstanley and others added 2 commits February 11, 2018 15:34
Content-Type set to 'application/json', but a string is being sent back. Update to send back a JSON object.
@abernix
Copy link
Member

abernix commented Apr 17, 2018

Thanks for opening this originally, and sorry we didn't get to this sooner. I've gone ahead and cleaned up and merged #753 which was a different take on this which instead utilizes Azure Functions' isRaw attribute, which should have a performance advantage over using JSON.parse for an object which will ultimately be re-stringified before going over the wire.

(I've posted this similar comment to #885, which was another attempt at the same change.)

@abernix abernix closed this Apr 17, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants