Use new audit IDs from graphql-http for filtering acceptable warnings
#7338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest minor in graphql-http adds unique and stable IDs for each audit. We can use these instead of substrings for explicitly filtering the audits we consider to be acceptable warnings.
✅ Deploy Preview for apollo-server-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e40c098:
|
glasser
approved these changes
Jan 27, 2023
|
@glasser yeah, the comment is helpful though. Also I think this unlocks a pretty easy way for integrations to skip particular tests that don't make sense for them (like the fastify one)...though I obviously didn't implement that yet. |
This was referenced Jan 27, 2023
Merged
trevor-scheer
pushed a commit
that referenced
this pull request
Feb 6, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @apollo/server-integration-testsuite@4.3.3 ### Patch Changes - [#7338](#7338) [`01bc39838`](01bc398) Thanks [@trevor-scheer](https://github.com/trevor-scheer)! - Update graphql-http to 1.13.0 - Updated dependencies \[[`9de18b34c`](9de18b3), [`8c635d104`](8c635d1)]: - @apollo/server@4.3.3 ## @apollo/server@4.3.3 ### Patch Changes - [#7331](#7331) [`9de18b34c`](9de18b3) Thanks [@trevor-scheer](https://github.com/trevor-scheer)! - Unpin `node-abort-controller` and update to latest unbreaking patch - [#7136](#7136) [`8c635d104`](8c635d1) Thanks [@trevor-scheer](https://github.com/trevor-scheer)! - Errors reported by subgraphs (with no trace data in the response) are now accurately reflected in the numeric error stats. Operations that receive errors from subgraphs (with no trace data in the response) are no longer sent as incomplete, error-less traces. Note: in order for this fix to take effect, your `@apollo/gateway` version must be updated to v2.3.1 or later. Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@enisdenjo kindly implemented an off-the-cuff feature request that I made via graphql/graphql-http#49. Now we can filter our expected audit warnings in an explicit and stable way.