Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error reporting when trace data is not included #7136

Merged
merged 21 commits into from
Feb 6, 2023
Merged

Fix error reporting when trace data is not included #7136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
4bee898
write test demonstrating current behavior
trevor-scheer Nov 8, 2022
9509307
update metrics interface
trevor-scheer Nov 9, 2022
760c56a
use updated gateway build, implement fix and update tests
trevor-scheer Nov 9, 2022
9efb148
Correctly count metrics w.r.t non-ftv1 errors
trevor-scheer Dec 6, 2022
6adca8b
package-lock update
trevor-scheer Dec 6, 2022
0621c25
polish
trevor-scheer Dec 6, 2022
674b565
Merge branch 'main' into trevor/usage-reporting-errors
trevor-scheer Jan 19, 2023
7d4804b
Update nonFtv1Errors -> nonFtv1ErrorPaths
trevor-scheer Jan 24, 2023
82afd7c
prettier
trevor-scheer Jan 24, 2023
4a6f39e
Incorporate subgraph name into root key
trevor-scheer Jan 24, 2023
0367f6a
snapshot updates
trevor-scheer Jan 24, 2023
52f8b64
extract and export NonFtv1ErrorPath interface
trevor-scheer Jan 24, 2023
12355d9
remove outdated comment
trevor-scheer Jan 24, 2023
5c19b5a
add comments
trevor-scheer Jan 24, 2023
57dd284
remove unused import
trevor-scheer Jan 24, 2023
c3ba88e
Complicate test cases for deeper errors including _entities
trevor-scheer Jan 25, 2023
b2b98f6
Merge branch 'main' into trevor/usage-reporting-errors
trevor-scheer Jan 25, 2023
e167da0
changeset
trevor-scheer Jan 25, 2023
e1b8122
add note about updating gateway
trevor-scheer Jan 26, 2023
d6c5293
Update to latest gateway version with necessary patch release
trevor-scheer Feb 6, 2023
5548ec0
Merge branch 'main' into trevor/usage-reporting-errors
trevor-scheer Feb 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .changeset/heavy-poets-wink.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
'@apollo/server': patch
---

Errors reported by subgraphs (with no trace data in the response) are now accurately reflected in the numeric error stats.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this changeset (and PR description) need to note that a particular version of Gateway is also needed to have the issue be actually fixed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in e1b8122 (with a FIXME to plug in final gateway version)


Operations that receive errors from subgraphs (with no trace data in the response) are no longer sent as incomplete, error-less traces.

Note: in order for this fix to take effect, your `@apollo/gateway` version must be updated to v2.3.1 or later.
Loading