fix(federation): Aggregate interfaces for types and interfaces #4497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For value types which implement interfaces, composition currently exhibits some unexpected behavior. Value types can implement whatever interfaces they'd like within their respective service, but that won't necessarily be represented within the composed schema. To resolve this, we need to aggregate all interfaces that an object or interface might implement and ensure those are represented in the composed schema. It's not important for every service to implement every interface that the others do, so in this sense we can be more permissive and allow each service to choose which interfaces a type or interface should implement locally.
abernix
approved these changes
Aug 21, 2020
abernix
pushed a commit
to apollographql/federation
that referenced
this pull request
Sep 4, 2020
…ographql/apollo-server#4497) For value types which implement interfaces, composition currently exhibits some unexpected behavior. Value types can implement whatever interfaces they'd like within their respective service, but that won't necessarily be represented within the composed schema. To resolve this, we need to aggregate all interfaces that an object or interface might implement and ensure those are represented in the composed schema. It's not important for every service to implement every interface that the others do, so in this sense we can be more permissive and allow each service to choose which interfaces a type or interface should implement locally. Apollo-Orig-Commit-AS: apollographql/apollo-server@3081569
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For value types which implement interfaces, composition currently
exhibits some unexpected behavior. Value types can implement whatever
interfaces they'd like within their respective service, but that won't
necessarily be represented within the composed schema.
To resolve this, we need to aggregate all interfaces that an object
or interface might implement and ensure those are represented in the
composed schema.
It's not important for every service to implement every interface
that the others do, so in this sense we can be more permissive and
allow each service to choose which interfaces a type or interface
should implement locally.