fix(federation): complex @keys result in unparseable CSDL
#4490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d105dfa to
58f03e5
Compare
abernix
approved these changes
Aug 18, 2020
58f03e5 to
8e6341d
Compare
@keys result in an unparseable document@keys result in unparseable CSDL
abernix
pushed a commit
to apollographql/federation
that referenced
this pull request
Sep 4, 2020
…aphql/apollo-server#4490) This fix targets a bug in printComposedSdl where @key directive fields args weren't being printed with reduced whitespace as @requires and @provides are, resulting in an invalid / unparseable graphql document. To reproduce this fix, I first introduced a nested @key into our testing fixtures, which we should have always had at least one of to begin with. The resulting bug can be seen in the second commit, and then resolved in the third commit. I've also added a test to printComposedSdl to ensure the output is parseable. Apollo-Orig-Commit-AS: apollographql/apollo-server@aa9ea85
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix targets a bug in
printComposedSdlwhere@keydirectivefieldsargsweren't being printed with reduced whitespace as
@requiresand@providesare,resulting in an invalid / unparseable graphql document.
To reproduce this fix, I first introduced a nested
@keyinto our testing fixtures,which we should have always had at least one of to begin with. The resulting bug
can be seen in the second commit, and then resolved in the third commit.
I've also added a test to
printComposedSdlto ensure the output is parseable.