Migrate testing fixtures to separate package #4411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit creates a new federation integration testing package. The main purpose of this package is to share testing fixtures between the gateway and federation packages, however this opens the door for more cross-package testing utilities in the future as well.
|
cc @abernix, this worked out swimmingly I think. Going to land this, happy to follow up with any changes or revert if necessary. |
trevor-scheer
added a commit
that referenced
this pull request
Jul 24, 2020
This PR creates a new federation integration testing package. The main purpose of this package is to share testing fixtures between the gateway and federation packages, however this opens the door for more cross-package testing utilities in the future as well.
abernix
pushed a commit
to apollographql/federation
that referenced
this pull request
Sep 4, 2020
…rver#4411) This PR creates a new federation integration testing package. The main purpose of this package is to share testing fixtures between the gateway and federation packages, however this opens the door for more cross-package testing utilities in the future as well. Apollo-Orig-Commit-AS: apollographql/apollo-server@c25b278
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a new federation integration testing package. The main purpose of this package is to share testing fixtures between the gateway and federation packages, however this opens the door for more cross-package testing utilities in the future as well.
Primary motivation for this comes from #4405, where I've found a desire to consume the testing fixtures from gateway within the federation package.