Colocate make-fetch-happen types within packages
#4333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hand-written make-fetch-happen types are required to exist within the packages that use them in order for them to build correctly when installed within another project. This reverts the portion of #4326 which moves these types to the top level of the project and duplicates them across the two packages which depend on them: apollo-gateway and apollo-server-plugin-operation-registry.
|
cc @abernix for awareness |
…apollographql/apollo-server into trevor/colocate-make-fetch-happen-types
abernix
pushed a commit
to apollographql/federation
that referenced
this pull request
Sep 4, 2020
…llo-server#4333) The hand-written make-fetch-happen types are required to exist within the packages that use them in order for them to build correctly when installed within another project. This reverts the portion of apollographql/apollo-server#4326 which moves these types to the top level of the project and duplicates them across the two packages which depend on them: apollo-gateway and apollo-server-plugin-operation-registry. Apollo-Orig-Commit-AS: apollographql/apollo-server@97c3acd
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hand-written
make-fetch-happentypes are required to exist within the packages that use them in order for them to build correctly when installed within another project.This reverts the portion of #4326 which moves these types to the top level of the project and duplicates them across the two packages which depend on them:
apollo-gatewayandapollo-server-plugin-operation-registry.Fixes #4332. Thanks @razorness for raising our attention to this so quickly!