Add support for passing options to http-cache-semantics in apollo-datasource-rest #4203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@harleynuss: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
harleynuss
commented
Jun 4, 2020
| @@ -1,4 +1,4 @@ | |||
| declare module 'http-cache-semantics' { | |||
| declare namespace CachePolicy { | |||
There was a problem hiding this comment.
The changes here would generally be cleaner to just switch to using the DefinitelyTyped definitions for this. However, DefinitelyTyped is implementing the documented API and the existing code is unfortunately using undocumented/internal methods.
|
@harleynuss can you bring this up to date with the base branch? |
16f13af to
0007e8b
Compare
Done |
af0a60e to
b545248
Compare
b545248 to
3174462
Compare
|
@abernix any insight into what happened here? |
|
Unintentional closing! Please stand-by: #4304 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apollo-datasource-rest uses http-cache-semantics to determine if a response is cachable. I ran into a problem where because of it’s opinionated nature it’s not caching something that I need it to. There are options to change this opinionated behavior, but apollo-datasource-rest isn’t set up in a way that those options can be passed. This PR allows the passing of those options.