fix(gateway): add missing apollo-server-errors runtime dependency.
#3927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apollo-server-errors runtime dependency.
abernix
approved these changes
Apr 22, 2020
abernix
added a commit
to apollographql/federation
that referenced
this pull request
Sep 4, 2020
…llographql/apollo-server#3927) Co-authored-by: Jesse Rosenberger <git@jro.cc> Apollo-Orig-Commit-AS: apollographql/apollo-server@63c9df2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I accidentally found out that apollo-gateway doesn't depend on apollo-server-errors directly in its package.json, but actually uses it.
This caused me an issue when I updated @apollo/gateway's major version (0.11 -> 0.13) in my project using
npm i apollo/gateway. This ended up in package.lock continuing using the previous version of apollo-server-errors (2.3.4 instead of 2.4.0) package as a top-level dependency, and, what is more important, being marked as a dev dependency (being used by my other dev dependency). So, when I tried to do a production npm install, apollo-server-errors dependency was being lost completely that caused a runtime error.