Federation: Preserve @deprecated type-system directives #3792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit resolves a breaking and unintentional change from #3736. While type-system directives _should_ be removed, @deprecated is a special case which can and should be left in.
7c6cb44 to
b19bb23
Compare
|
Thanks @trevor-scheer ! Should we |
abernix
approved these changes
Feb 14, 2020
abernix
reviewed
Feb 14, 2020
abernix
pushed a commit
to apollographql/federation
that referenced
this pull request
Sep 4, 2020
…l/apollo-server#3792) This commit resolves a breaking and unintentional change from apollographql/apollo-server#3736. While type-system directives _should_ be removed, @deprecated is a special case which can and should be left in. Co-authored-by: Jesse Rosenberger <git@jro.cc> Apollo-Orig-Commit-AS: apollographql/apollo-server@6005f50
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit resolves a breaking and unintentional change from #3736.
While type-system directives should be removed, @deprecated is a
special case which can and should be left in.