-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix imports of validation rules from 'graphql-js' #3727
Conversation
@@ -20,6 +20,6 @@ | |||
"lodash.xorby": "^4.7.0" | |||
}, | |||
"peerDependencies": { | |||
"graphql": "^14.0.2" | |||
"graphql": "^14.6.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abernix Can you update this peer dependency to 14.6.0
?
It shouldn't be any breaking changes between 14.0.2
and 14.6.0
so it should be a pretty safe update for end-users.
But if it is not possible we can try to figure out other ways to support both ^14.0.2
and 15.0.0
in your code base.
For context please see: graphql/graphql-js#2402
@IvanGoncharov After graphql/graphql-js#2413 had been opened as a result of your conversation with @trevor-scheer, I was under the impression that we might not actually ship this PR right now. I now see #3741 has been opened as well (also, @trevor-scheer just went on vacation, so I'm unable to ask him). I was believing that instead wait until we bump Apollo's major versions, which would be more appropriate for a major version update since Again, we're happy to make these all happen in major version bumps, so maybe this PR and #3741 should just be targeted for our 3.x branch? (And we should start a similar branch, soon, on |
@IvanGoncharov @trevor-scheer Excuse me / Nevermind, I mis-analyzed this. While I think some parts of the above are true, I don't think #3741 needs to target a major version, though this one probably should. |
@abernix Yes definitely. I opened it before our Slack discussion and just forgot to close. |
For context please see: graphql/graphql-js#2402
@abernix it's a pre-request for
15.0.0
support.