Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix imports of validation rules from 'graphql-js' #3727

Closed
wants to merge 1 commit into from
Closed

Fix imports of validation rules from 'graphql-js' #3727

wants to merge 1 commit into from

Conversation

IvanGoncharov
Copy link
Member

For context please see: graphql/graphql-js#2402
@abernix it's a pre-request for 15.0.0 support.

@@ -20,6 +20,6 @@
"lodash.xorby": "^4.7.0"
},
"peerDependencies": {
"graphql": "^14.0.2"
"graphql": "^14.6.0"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abernix Can you update this peer dependency to 14.6.0?
It shouldn't be any breaking changes between 14.0.2 and 14.6.0 so it should be a pretty safe update for end-users.
But if it is not possible we can try to figure out other ways to support both ^14.0.2 and 15.0.0 in your code base.

@abernix abernix modified the milestones: 2.10.0, Release 2.10.0 Jan 27, 2020
@abernix
Copy link
Member

abernix commented Jan 31, 2020

@IvanGoncharov After graphql/graphql-js#2413 had been opened as a result of your conversation with @trevor-scheer, I was under the impression that we might not actually ship this PR right now. I now see #3741 has been opened as well (also, @trevor-scheer just went on vacation, so I'm unable to ask him).

I was believing that instead wait until we bump Apollo's major versions, which would be more appropriate for a major version update since peerDependencies don't otherwise give clear enough warning to users, but mostly because of the need for there to be exactly one copy of graphql in a project and the resulting problems that come from that with, e.g. the apollo CLI which brings graphql for its own purposes, even though apollo is expected work within a user's project which might need their own version requirement.

Again, we're happy to make these all happen in major version bumps, so maybe this PR and #3741 should just be targeted for our 3.x branch? (And we should start a similar branch, soon, on apollo-tooling — the home of apollo).

@abernix
Copy link
Member

abernix commented Jan 31, 2020

@IvanGoncharov @trevor-scheer Excuse me / Nevermind, I mis-analyzed this. While I think some parts of the above are true, I don't think #3741 needs to target a major version, though this one probably should.

@IvanGoncharov
Copy link
Member Author

@abernix Yes definitely. I opened it before our Slack discussion and just forgot to close.

@abernix abernix added this to the Release 3.x milestone Jan 31, 2020
@glasser glasser removed this from the Release 3.x milestone Jun 10, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants