Fix double instantiation of DataSources #3388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, buildService is being called twice for each service on gateway startup. This is because we're caching the datasources, but failing to utilize the cache. This commit places the creation and caching of datasources in one place, and indicates this more clearly with an updated function name.
abernix
pushed a commit
to apollographql/federation
that referenced
this pull request
Sep 4, 2020
…3388) Currently, buildService is being called twice for each service on gateway startup. This is because we're caching the datasources, but failing to utilize the cache. This commit places the creation and caching of datasources in one place, and indicates this more clearly with an updated function name. Fixes apollographql/apollo-server#3367 Apollo-Orig-Commit-AS: apollographql/apollo-server@edbc829
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, buildService is being called twice for each service on
gateway startup. While we are caching the datasources,
we're failing to utilize the cache.
This commit places the creation and caching of datasources in one
place, and indicates this more clearly with an updated function
name.
Fixes #3367