Remove federation directives from composed schema #3272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbaxleyiii
approved these changes
Sep 9, 2019
abernix
pushed a commit
to apollographql/federation
that referenced
this pull request
Sep 4, 2020
…lo-server#3272) Rebuild schema with only specified directives. The federation directives are only needed during composition, as all of the directives are effectively consumed / transformed into metadata on the schema nodes. Apollo-Orig-Commit-AS: apollographql/apollo-server@5f2fe21
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to prune federation directives from the composed schema. These are only needed during composition, as all of the directives are effectively consumed / transformed into metadata on the schema nodes.