Fix bug in externalUnused validation #2919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When looping through a fieldSet's selections, the selectionIncludesField function could return false prematurely. Instead, it should continue looping through all the adjacent selections before either returning true at some point or finally returning false if the true case is never encountered.
d9d6b85 to
2442f44
Compare
evans
approved these changes
Jun 25, 2019
There was a problem hiding this comment.
Looks good to me!
Nice catch on https://github.com/apollographql/apollo-server/pull/2919/files#diff-73294e765af4bec01240904fd583c4e9R300
abernix
pushed a commit
to apollographql/federation
that referenced
this pull request
Sep 4, 2020
When looping through a fieldSet's selections, the selectionIncludesField function could return false prematurely. Instead, it should continue looping through all the adjacent selections before either returning true at some point or finally returning false if the true case is never encountered. Apollo-Orig-Commit-AS: apollographql/apollo-server@68f3124
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looping through a
fieldSet's selections, theselectionIncludesFieldfunction could return false prematurely. Instead, it should continue
looping through all the adjacent selections before either returning
true at some point or finally returning false if the true case is
never encountered.