Ignore __proto__ fields in deepMerge() #2779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abernix
pushed a commit
to apollographql/federation
that referenced
this pull request
Sep 4, 2020
) This resolves a security issue within @apollo/gateway. The deepMerge function is open to a known attack vector called prototype pollution. Prototype pollution allows a user to "pollute" Object.prototype, thereby polluting all Objects with Object.prototype in their prototype chain. This function is currently only in use by @apollo/gateway. Apollo-Orig-Commit-AS: apollographql/apollo-server@69e4854
excenter
reviewed
Aug 2, 2022
| @@ -4,7 +4,7 @@ export function deepMerge(target: any, source: any): any { | |||
| if (source === undefined || source === null) return target; | |||
|
|
|||
| for (const key of Object.keys(source)) { | |||
| if (source[key] === undefined) continue; | |||
| if (source[key] === undefined || key === '__proto__') continue; | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The purpose of this PR is to resolve a security issue within
@apollo/gateway. ThedeepMergefunction is open to a known attack vector called prototype pollution. Prototype pollution allows a user to "pollute"Object.prototype, thereby polluting allObjectswithObject.prototypein their prototype chain.This function is currently only in use by the new
@apollo/gateway.Impact and resolution
Vulnerable versions of
@apollo/gatewayinclude all<=0.6.1. A release of version0.6.2will follow the merging of this PR shortly and resolve the issue.