-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apollo-server-azure-function first implementation. #1753
Conversation
Closes apollographql#1752. Added info about azure-function and cloud-function to readme.md
@leo-buneev: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
Codecov Report
@@ Coverage Diff @@
## master #1753 +/- ##
===========================================
- Coverage 90.2% 74.49% -15.71%
===========================================
Files 5 31 +26
Lines 194 1243 +1049
Branches 38 329 +291
===========================================
+ Hits 175 926 +751
- Misses 18 306 +288
- Partials 1 11 +10
Continue to review full report at Codecov.
|
@leo-buneev thanks for the good work on this. It seems like PR is stuck in the review process. Can you please rebase the branch again so someone from the core team can review and merge it. I can really use the Azure function support in Apollo Server. |
@hsdhillon Sure, will do tomorrow. |
- Introduced willStart call from ApolloServerBase in the createHandler. This is similar to what is done in Lambda. - Update scripts for compiling - Bumbp version to alpha
Include reference to apollo-server-function into tsconfig for testing and the root project package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple changes, but I think we can get this into an alpha
release! @michaelwatson93 went ahead and applied the appropriate updates from the master
branch (since many changes are not easily or intuitively mergeable) and I've followed up with a couple changes to the package-lock.json
and README.md
/CHANGELOG.md
.
}; | ||
}; | ||
|
||
export enum HttpStatusCodes { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be great if we could include these definitions from somewhere else!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried to use existing external definitions, but they were incomplete/outdated.
Do you think I should publish typings as a separate package?
Published as |
Thank you so much for working on this @leo-buneev! (And thanks to @michael-watson for wrapping it up!) |
Thanks for your work @leo-buneev and thanks to @abernix for merging and publishing the package. I quickly wanted to point out that package is published as apollo-server-azure-function whereas the documentation refers to package name with "s" at the end. apollo-server-azure-functions points to package with 1.x release. Attached screenshot shows the search result on npmjs |
I'm happy to help. @abernix @michaelwatson93 thank you for wrapping it up and merging! |
@leo-buneev : Thanks for the awesome work 🙌 When will this be available to use? Also, I saw that the name is Can you please help me with this 🙂 |
I think this is |
I am unable to get this to work, I get a blank screen at the moment. Here is a reproduction: https://github.com/divyenduz/apoll-server-azure-function |
Ah! this worked, after using |
Glad you got it working @divyenduz ! Maybe we should make that portion more clear in the documentation. |
Closes #1752.
Added info about azure-function and cloud-function to readme.md
TODO: