Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently merged a PR that adds support for Google Cloud Functions to Apollo Server.
It turns our the integration tests weren't actually being run because they weren't under a
__tests__
directory. After changing that, the tests unfortunately all fail.From what I can see, this is caused by
apollo-server-integration-testsuite
expecting request and response types to be of the underlying Node types and not Express types, as can be seen in the Lambda integration:apollo-server/packages/apollo-server-lambda/src/__tests__/lambdaApollo.test.ts
Line 17 in a730108
@reaktivo: Would you be able to take another look at this? I assume things are actually working for you, but we also need the tests to pass to assure the integration behaves as expected.
@tgriesser: Since you added types in https://github.com/apollographql/apollo-server/pull/1554/files, maybe you also want to chime in?