Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Cloud Functions tests #1601

Closed
wants to merge 3 commits into from

Conversation

martijnwalraven
Copy link
Contributor

We recently merged a PR that adds support for Google Cloud Functions to Apollo Server.

It turns our the integration tests weren't actually being run because they weren't under a __tests__ directory. After changing that, the tests unfortunately all fail.

From what I can see, this is caused by apollo-server-integration-testsuite expecting request and response types to be of the underlying Node types and not Express types, as can be seen in the Lambda integration:

return (req: IncomingMessage, res: ServerResponse) => {

@reaktivo: Would you be able to take another look at this? I assume things are actually working for you, but we also need the tests to pass to assure the integration behaves as expected.

@tgriesser: Since you added types in https://github.com/apollographql/apollo-server/pull/1554/files, maybe you also want to chime in?

@reaktivo
Copy link
Contributor

reaktivo commented Sep 3, 2018

I'll have a look later today, I tried yesterday and I was only able to see an error with the express adapter

This was referenced Sep 4, 2018
@reaktivo
Copy link
Contributor

reaktivo commented Sep 5, 2018

@martijnwalraven Sorry for the delay, I've created a new PR to make the test actually run and also including some issues that were discovered by the integration tests

#1616

@abernix abernix deleted the google-cloud-functions-tests branch December 3, 2018 12:29
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants