Always clone the context if it's not a function

Fixes #1247.
apollographql · Jun 26, 2018 · 7e35305 · 7e35305
1 parent 84f13ba
commit 7e35305
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/packages/apollo-server-core/src/runHttpQuery.ts b/packages/apollo-server-core/src/runHttpQuery.ts
@@ -303,7 +303,9 @@ export async function runHttpQuery(
           e.message = `Context creation failed: ${e.message}`;
           throwHttpGraphQLError(500, [e], optionsObject);
         }
-      } else if (isBatch) {
+      } else {
+        // Always clone the context if it's not a function, because that preserves
+        // having a fresh context per request.
         context = Object.assign(
           Object.create(Object.getPrototypeOf(context)),
           context,