-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GraphManager/Engine Headers + minor WebSocket cleanup #858
Conversation
if version.isEmpty { | ||
version.append(buildNumber) | ||
} else { | ||
version.append("-\(buildNumber)") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually decided against this on my end as I'm increasing the build number on each build (based of number of commits) and it makes the "Clients" view in Apollo Engine a bit noisy for the non-public environments/variants. YMMV of course and it's always configurable anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah in my past experience when I've had build number auto-incrementing it's actually been quite helpful in being able to identify exactly where I broke something 😄. And as you said, it's configurable, so if people don't like the default, they can always adjust.
20b316f
to
c925993
Compare
c925993
to
adb8586
Compare
… sure headers are actually sent
adb8586
to
6aa8c62
Compare
In this PR: