Make buildable when using SPM in XCode 11 #784
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried adding apollo to our project using SPM in XCode 11 and got some build issues.
The first issue was due to the swift version being specified to 4.0 in
Package.swift
, making XCode trying to build this with the old toolchain, leading to a build error at:apollo-ios/Sources/Apollo/GraphQLHTTPResponseError.swift
Line 39 in beb6127
Due to this depending on the nil-coalescing feature in swift 5.0, changing the
swift-tools-version
inPackage.swift
fixes this.When this was fixed I got some build-errors due to
Foundation
not being imported in two files, so I added this as well.