Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webtransport delegate #379

Conversation

psi-gh
Copy link
Contributor

@psi-gh psi-gh commented Oct 1, 2018

  • feature
  • blocking

Added delegate for webTransport which can handle connection/reconnection/disconnection events of websocket.

Why need it:
If you have subscriptions, and websocket reconnected for some reason (when app in background or internet connection is weak), eventually you want to handle it and retrieve missed data which could appear on backend when your websocket connection (-> all subscriptions) was down.

Done in a similar way with JS version of Apollo (with callbacks for SubscriptionClient)

@ghost ghost added blocking Prevents production or dev due to perf, bug, build error, etc.. feature New addition or enhancement to existing solutions labels Oct 1, 2018
@martijnwalraven martijnwalraven merged commit 474ee9c into apollographql:master Oct 4, 2018
@martijnwalraven
Copy link
Contributor

Thanks, this looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocking Prevents production or dev due to perf, bug, build error, etc.. feature New addition or enhancement to existing solutions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants