Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for multi-variable uploads #1279

Merged
merged 2 commits into from
Jun 30, 2020
Merged

Conversation

designatednerd
Copy link
Contributor

Thanks to @vandyshev for pointing this out in #1081. The solution there unfortunately wound up hammering arrays of files, but it gave me a place to start for this bit which works with both multiple files with the same field name and multiple files with different field names.

Previously, we were appending an index to every field name when uploading multiple files. This worked if the files all had the same name, but did not if they had different names. This PR makes updates to ensure that if you are uploading multiple files with different variable names, the correct variable name is included.

The testMultipleFilesWithMultipleFieldsWithApolloRequestCreator test case will show the expected output.

@designatednerd designatednerd force-pushed the fix/upload-multi-variable branch from 492191d to 4dbde0c Compare June 30, 2020 15:32
@designatednerd
Copy link
Contributor Author

Gonna go ahead and merge this one and put it out with the next version of the lib.

@designatednerd designatednerd merged commit 00d3869 into main Jun 30, 2020
@designatednerd designatednerd deleted the fix/upload-multi-variable branch June 30, 2020 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant