Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to set the SSLTrustValidator for websocket #1124

Merged

Conversation

ketenshi
Copy link
Contributor

@ketenshi ketenshi commented Apr 6, 2020

A use case could be SSL Pinning.

Alternatively this can go into the initializer if it makes more sense there.

@apollo-cla
Copy link

@ketenshi: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@designatednerd
Copy link
Contributor

If you can make that update and sign the CLA, this seems like a reasonable addition.

@designatednerd designatednerd merged commit 92fbaea into apollographql:master Apr 7, 2020
@designatednerd designatednerd added this to the Next Release milestone Apr 7, 2020
@ketenshi ketenshi deleted the add/websocket-security branch April 7, 2020 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants