Workaround CLI argument parsing issue #1096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Re-opening PR, accidentally deleted branch. |
designatednerd
approved these changes
Mar 22, 2020
|
@sfoulston D'oh! I merged your other PR and there's now a merge conflict - can you take a look at that when you have a chance? Otherwise this is good to go. |
|
No worries, just coincidence my two PRs touched the same bit of code! Have resolved & merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to an underlying issue with the Oclif framework that the Apollo CLI uses, the
schema:downloadcommand (at least) fails when--headerarguments are not placed at the end of the command, such as when specifying a non-default output path. The ApolloCodegenLib places the output path after the header argument, so the schema download always fails.This PR just moves the header argument to the end of the bash command by reordering the array of arguments in
ApolloSchemaOptions#arguments.See also:
apollographql/apollo-tooling#844 (comment)