chore: Create draft release for apollo-ios-codegen when publishing a release
#435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for eclectic-pie-88a2ba canceled.
|
✅ Deploy Preview for apollo-ios-docc canceled.
|
calvincestari
commented
Jul 19, 2024
|
Merging and we'll monitor for any issues when we do the next release. |
BobaFetters
reviewed
Jul 30, 2024
| - [ ] Run the []'Publish Release' workflow](https://github.com/apollographql/apollo-ios-dev/actions/workflows/publish-release.yml) in apollo-ios-dev |
There was a problem hiding this comment.
Do we need this step? The Publish Release workflow should run automatically when merging release PRs
There was a problem hiding this comment.
The trigger is set to workflow_dispatch which from the Actions documentation indicates it's a manual trigger. Am I interpreting that incorrectly?
There was a problem hiding this comment.
Yea so that means the workflow can be manually triggered, I believe it's also needed to allow dispatching from other workflows (although i could be wrong there) but we have it being dispatched here
There was a problem hiding this comment.
Ah, I see. OK, I'll get another PR up to remove that step - apologies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing the release for 1.14.0 I noticed that there was no draft release created in the
apollo-ios-codegenrepo and I had to manually create releases for 1.13.0 and 1.14.0. This should now do that automatically for us.