Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defer: Local cache mutation writes #421

Merged
merged 4 commits into from
Jul 19, 2024

Conversation

calvincestari
Copy link
Member

@calvincestari calvincestari commented Jul 9, 2024

Getting local cache mutation cache writes working with operations that use @defer.

  • Removes the assertionFailure and collects fields to execute if the deferred fragment is marked as fulfilled.
  • Updates documentation for cache write caveat (using private DataDict initializer).
  • Removes old TODO markers, test reminders, etc.

@calvincestari calvincestari changed the title defer: cleaning up defer: Local cache mutation writes Jul 17, 2024
@calvincestari calvincestari marked this pull request as ready for review July 18, 2024 22:50
@calvincestari calvincestari mentioned this pull request Jul 19, 2024
8 tasks
Copy link
Contributor

@AnthonyMDev AnthonyMDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@calvincestari calvincestari merged commit 6b78529 into feature/defer-execution-networking Jul 19, 2024
11 of 23 checks passed
@calvincestari calvincestari deleted the defer/clean-up branch July 19, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants