Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fixing release-check workflow #398

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Conversation

BobaFetters
Copy link
Member

The release-check workflow keeps failing integration tests due to a node installation error:

Attempting to download 12.22.10...
Not found in manifest. Falling back to download directly from Node
Error: Unable to find Node version '[12](https://github.com/apollographql/apollo-ios-dev/actions/runs/9631580897/job/26563574892#step:4:13).22.10' for platform darwin and architecture arm64.

The integration tests pass on the ci-tests workflow that runs on PR's, it looks like the release-check workflow had the integration tests job updated to use macos-latest like the rest of the jobs while the ci-tests workflow is still using macos-13 for the integration tests and this issue appears to be stemming from the switch from macos-13 to macos-14 for the runner.

Other discussion of the same issue here: actions/setup-node#1017 (comment)

Reverting the integration tests job to macos-13 for now to get this passing again but we will need to upgrade the node version to be able to bring this job forward to macos-14.

@BobaFetters BobaFetters self-assigned this Jun 24, 2024
Copy link

netlify bot commented Jun 24, 2024

Deploy Preview for eclectic-pie-88a2ba canceled.

Name Link
🔨 Latest commit 176b155
🔍 Latest deploy log https://app.netlify.com/sites/eclectic-pie-88a2ba/deploys/6678f480606c180008d6fd56

Copy link

netlify bot commented Jun 24, 2024

Deploy Preview for apollo-ios-docc canceled.

Name Link
🔨 Latest commit 176b155
🔍 Latest deploy log https://app.netlify.com/sites/apollo-ios-docc/deploys/6678f480850bb00008cf2e4d

Copy link
Member

@calvincestari calvincestari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Zach. This is required because the StarWars test server is still on an ancient version of Apollo Server and needs that old version of Node.

@calvincestari calvincestari merged commit bbf74cc into main Jun 24, 2024
23 checks passed
@calvincestari calvincestari deleted the ci/main-branch-test-fix branch June 24, 2024 16:53
BobaFetters added a commit that referenced this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants