-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci]: Tooling update #254
[ci]: Tooling update #254
Conversation
✅ Deploy Preview for eclectic-pie-88a2ba canceled.
|
./scripts/install-tuist.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tuist installation is now under our control in a local script.
needs: [changes] | ||
if: ${{ needs.changes.outputs.ios == 'true' || needs.changes.outputs.codegen == 'true' || needs.changes.outputs.pagination == 'true' }} | ||
if: ${{ needs.changes.outputs.ios == 'true' || needs.changes.outputs.codegen == 'true' || needs.changes.outputs.pagination == 'true' || needs.changes.outputs.tuist == 'true' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tuist-generation job should run whenever we change the pinned Tuist version.
with: | ||
command: 'generate' | ||
arguments: '' | ||
uses: ./.github/actions/run-tuist-generation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already had a local action but it wasn't being used. This drops the broken tuist-action from the marketplace and uses our own one that we can control.
} | ||
|
||
# The line below extracts the version from the local .tuist-version file and installs that version tag from the github releases. | ||
LATEST_VERSION=$(cat .tuist-version) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The installed Tuist version will always match what we've pinned it to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's worth noting that this installation never actually installs Tuist itself but rather tuistenv
which was their prior version manager, and what they're moving away from in favour of mise. If you look at the terminal output the actual Tuist version is installed when you issue the first command, such as generate
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Nice work!
The release of Tuist
4.0.0-beta-1
appears to have broken our workflow. It looks like they're trying to fix the environment but we should stay on 3.x until 4 is stable.The aim of this PR was to fix Tuist which it does by:
3.42.2
.Other changes in this PR:
macos-14
.15.2
.