Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add privacy manifest for Apollo targets #251

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Add privacy manifest for Apollo targets #251

merged 2 commits into from
Jan 31, 2024

Conversation

BobaFetters
Copy link
Member

@BobaFetters BobaFetters self-assigned this Jan 26, 2024
@BobaFetters BobaFetters requested a review from a team as a code owner January 26, 2024 18:49
@netlify Netlify
Copy link

netlify bot commented Jan 26, 2024 •
edited
Loading

✅ Deploy Preview for eclectic-pie-88a2ba canceled.

Name Link
🔨 Latest commit 1f82eae
🔍 Latest deploy log https://app.netlify.com/sites/eclectic-pie-88a2ba/deploys/65b97bc8989f6c0008a203e9

@calvincestari
Copy link
Member

I think we may need to add that file extension to the podspec too - resource_bundles

calvincestari
calvincestari reviewed Jan 31, 2024
View reviewed changes
Copy link
Member

@calvincestari calvincestari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good @BobaFetters. I don't think there is a way for us to test this except for installing with each dependency manager and then manually inspecting that the privacy manifest file exists? That seems a bit much for something like this that isn't likely to change - thoughts?

Also, the pod spec lint error we were getting earlier is still present but I believe it's related to versioning and tags. Not sure if we need to worry about that.

@BobaFetters
Copy link
Member Author

@calvincestari Yea we would need to have projects for each dependency manager, archive them, and then inspect the archive I think to ensure the privacy manifest was in the archive. But no I'm not sure that's necessary for this honestly.

Maybe something we can look at fixing separately if its not directly related to these changes?

@BobaFetters BobaFetters merged commit d85e316 into main Jan 31, 2024
20 checks passed
@BobaFetters BobaFetters deleted the privacy-manifest branch January 31, 2024 18:24
BobaFetters added a commit that referenced this pull request Jan 31, 2024
@BobaFetters
Add privacy manifest for Apollo targets (#251)
29cf3c2
BobaFetters added a commit to apollographql/apollo-ios that referenced this pull request Jan 31, 2024
@BobaFetters
Add privacy manifest for Apollo targets (apollographql/apollo-ios-dev…
6a918a5 
…#251)
BobaFetters pushed a commit that referenced this pull request Jan 31, 2024
Squashed 'apollo-ios/' changes from 6bdaf4e..6a918a5
65e493a 
6a918a5 Add privacy manifest for Apollo targets (#251)

git-subtree-dir: apollo-ios
git-subtree-split: 6a918a5
BobaFetters pushed a commit that referenced this pull request Jan 31, 2024
split: apollo-ios - PR #251 - Add privacy manifest for Apollo targets
d12ef51 
git-subtree-dir: apollo-ios
git-subtree-mainline: 29cf3c2
git-subtree-split: 6a918a5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calvincestari calvincestari calvincestari approved these changes

@AnthonyMDev AnthonyMDev Awaiting requested review from AnthonyMDev

Assignees

@BobaFetters BobaFetters

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add PrivacyManifest
2 participants
@BobaFetters @calvincestari