Release/1.7.1 #133
Merged
Release/1.7.1 #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobaFetters
reviewed
Nov 13, 2023
BobaFetters
approved these changes
Nov 13, 2023
Co-authored-by: Zach FettersMoore <zach.fetters@apollographql.com>
|
|
||
| ### Fixed | ||
|
|
||
| - **Fixed inconsistent ordering of fragments in generated operation definitions ([#130](https://github.com/apollographql/apollo-ios-dev/pull/130)):** In order to make the ordering of fragments consistent, they are not alphabetized. This is a change to the data that gets sent over the wire when making a network request for an operation with fragments. **[Persisted Queries](https://www.apollographql.com/docs/ios/fetching/persisted-queries) users should re-register their queries when upgrading to this version.** _Thank you to [@scottasoutherland](https://github.com/scottasoutherland) for reporting the issue._ |
There was a problem hiding this comment.
they are not alphabetized
Is this meant to be "they are now alphabetized"?
There was a problem hiding this comment.
lol yes. thanks. good catch
There was a problem hiding this comment.
Should we mention anything about what it was before, i.e.: "they are now alphabetized vs. the order listed in the operation"?
BobaFetters
pushed a commit
that referenced
this pull request
Nov 13, 2023
BobaFetters
pushed a commit
to apollographql/apollo-ios
that referenced
this pull request
Nov 13, 2023
BobaFetters
pushed a commit
to apollographql/apollo-ios-codegen
that referenced
this pull request
Nov 13, 2023
BobaFetters
pushed a commit
that referenced
this pull request
Nov 13, 2023
BobaFetters
pushed a commit
that referenced
this pull request
Nov 13, 2023
ae21fc9b Release/1.7.1 (#133) git-subtree-dir: apollo-ios-codegen git-subtree-split: ae21fc9bdd9750eb7b471e002d74c358d1d14fec
BobaFetters
pushed a commit
that referenced
this pull request
Nov 13, 2023
git-subtree-dir: apollo-ios-codegen git-subtree-mainline: e021430 git-subtree-split: ae21fc9bdd9750eb7b471e002d74c358d1d14fec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diff
See diff since last version.
Things to do in this PR
set-version.shscript.CHANGELOG.mdwith all relevant changes since the prior version. Please include PR numbers and mention contributors for external PR submissions.SwiftScriptsfolder using the commandswift run DocumentationGeneratorto re-generate the API reference documentation from source for all included libraries. Make sure you are on HEAD of the parent branch otherwise the documentation generator will not catch all changes, rebase this PR if needed.make archive-cli-to-apollo-packageto attach cli to apollo-ios packageThings to do as part of releasing
major.minor.patchto GitHub.CHANGELOG.mdcontents.make archive-cli-for-releasecommand which builds both Intel and ARM architectures, and creates the tar archive for you.pod trunk push Apollo.podspecandpod trunk push ApolloTestSupport.podspecto publish to CocoaPods. You will need write permissions for this, please contact one of the maintainers if you need access to do this.apollo-ios-xcframework