refactor: Remove redundant iteration in EntitySelectionTree merging a…

…lgorithm (#308)
apollographql · Mar 22, 2024 · a8fcb77 · a8fcb77
1 parent b90f662
commit a8fcb77
Showing 1 changed file with 2 additions and 17 deletions.
diff --git a/apollo-ios-codegen/Sources/IR/IR+EntitySelectionTree.swift b/apollo-ios-codegen/Sources/IR/IR+EntitySelectionTree.swift
@@ -224,23 +224,6 @@ class EntitySelectionTree {
           targetSelections.mergeIn(scopeSelections, from: source)
         }
 
-        if let conditionalScopes = scopeConditions {
-          for (condition, node) in conditionalScopes {
-            guard !node.scope.isDeferred else { continue }
-
-            if scopePathNode.value.matches(condition) {
-              node.mergeSelections(
-                matchingScopePath: scopePathNode,
-                into: targetSelections,
-                transformingSelections: transformingSelections
-              )
-
-            } else {
-              targetSelections.addMergedInlineFragment(with: condition)
-            }
-          }
-        }
-
       case .none: break
       }
 
@@ -254,6 +237,8 @@ class EntitySelectionTree {
               into: targetSelections,
               transformingSelections: transformingSelections
             )
+          } else if case .selections = child {
+            targetSelections.addMergedInlineFragment(with: condition)
           }
         }
       }