Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer existing.pageInfo cursors in relayStylePagination field policy read functions #8438

Merged
merged 2 commits into from
Jun 29, 2021
Merged

Prefer existing.pageInfo cursors in relayStylePagination field policy read functions #8438

merged 2 commits into from
Jun 29, 2021

Conversation

benjamn
Copy link
Member

@benjamn benjamn commented Jun 28, 2021 •
edited
Loading

Should fix #8267, taking inspiration from @migueloller's suggestion in #8267 (comment).

@benjamn benjamn added this to the June 2021 milestone Jun 28, 2021
@benjamn benjamn requested a review from brainkim June 28, 2021 23:44
@benjamn benjamn self-assigned this Jun 28, 2021
@benjamn benjamn force-pushed the issue-8267-relayStylePagination-default-cursors branch from 330808b to 25fed77 Compare June 28, 2021 23:48
@benjamn benjamn linked an issue Jun 28, 2021 that may be closed by this pull request
relayStylePagination read method clobbers pageInfo.startCursor and pageInfo.endCursor #8267
Closed
@benjamn benjamn mentioned this pull request Jun 28, 2021
Closed
@benjamn benjamn force-pushed the issue-8267-relayStylePagination-default-cursors branch from 3899ffe to c65b337 Compare June 29, 2021 00:05
@benjamn benjamn changed the base branch from release-3.4 to main June 29, 2021 00:06
@benjamn benjamn force-pushed the issue-8267-relayStylePagination-default-cursors branch from c65b337 to 0e134b9 Compare June 29, 2021 18:26
@benjamn benjamn changed the title Prefer existing.pageInfo cursors in relayStylePagination read function Prefer existing.pageInfo cursors in relayStylePagination field policy read functions Jun 29, 2021
@benjamn benjamn merged commit f9f8bef into main Jun 29, 2021
@benjamn benjamn deleted the issue-8267-relayStylePagination-default-cursors branch June 29, 2021 18:39
@hwillson hwillson removed this from the MM-2021-06 milestone Jul 29, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@brainkim brainkim Awaiting requested review from brainkim

Assignees

@benjamn benjamn

Labels
🐞 bug 💸 caching 🧪 has-tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

relayStylePagination read method clobbers pageInfo.startCursor and pageInfo.endCursor
2 participants
@benjamn @hwillson