Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recheck rv() against previous value in useEffect callback in useReactiveVar #8135

Merged
merged 3 commits into from
May 4, 2021
Merged

Recheck rv() against previous value in useEffect callback in useReactiveVar #8135

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9f078f0
Recheck rv() against previous value in useIsomorphicEffect.
benjamn May 4, 2021
5ec07e5
Unwind remaining workarounds in useReactiveVar.
benjamn May 4, 2021
9555675
Mention PRs #8126 and #8135 in CHANGELOG.md.
benjamn May 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,13 @@
## Apollo Client 3.3.17 (not yet released)

### Bug fixes

- Prevent warnings about `useLayoutEffect` when using `useReactiveVar` during React server rendering. <br/>
brainkim marked this conversation as resolved.
Show resolved Hide resolved
[@brainkim](https://github.com/brainkim) in [#8126](https://github.com/apollographql/apollo-client/pull/8126)

- Make `useReactiveVar(rv)` recheck the latest `rv()` value in its `useEffect` callback, and immediately update state if the value has already changed, rather than calling `rv.onNextChange(setValue)` to listen for future changes. <br/>
[@benjamn](https://github.com/benjamn) in [#8135](https://github.com/apollographql/apollo-client/pull/8135)

## Apollo Client 3.3.16

### Bug fixes
Expand Down