Prevent new data re-render attempts during an existing render #6107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6107 +/- ##
==========================================
- Coverage 95.37% 95.28% -0.10%
==========================================
Files 88 88
Lines 3653 3666 +13
Branches 903 875 -28
==========================================
+ Hits 3484 3493 +9
- Misses 146 150 +4
Partials 23 23
Continue to review full report at Codecov.
|
|
Please hold on the review of this @benjamn. The solution implemented in apollographql/react-apollo#3902 did not fix the problem in all cases. I'm working on a more complete solution and will update this PR shortly. Thanks! |
342d8ab to
1e7368b
Compare
|
@benjamn this is now ready for review. Thanks! |
Prevent new data re-render attempts during an existing render to help avoid React 16.13.0's "Cannot update a component from inside the function body of a different component" warning (facebook/react#17099). These changes were originally implemented in apollographql/react-apollo#3930.
benjamn
added a commit
that referenced
this pull request
May 5, 2020
This version does *not* include my big PR #6221, which should be coming in the _next_ beta release. Code changes in beta.45 (since beta.44) include * #6194 by @durchanek * #6107 by @hwillson as well as several documentation PRs.
|
Don’t mind me just putting this link here for posterity (me) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of version 16.13.0, React logs a warning when a function component is updated during another component's render phase (facebook/react#17099). In Apollo Client this warning can be triggered when nesting multiple components that leverage
useQuery. To help avoid this, this commit ensures re-render requests to show new data are delayed until an effect hook is run to handle them (since we're then out of the render phase).These changes were originally implemented in apollographql/react-apollo#3902.