chore: set react version to the one in RN 0.59 #5499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @SimenB! Now that npm/cli#224 has landed, we're going to switch to a combination of |
hwillson
approved these changes
Oct 24, 2019
NPM just launched optional peer dependency support via `peerDependenciesMeta` (npm/cli#224), so we can now leverage this to make `react` a trully optional dep, instead of using NPM's poorly named `optionalDependencies` (since `optionalDependencies` are really just normal dependencies). This means people using `@apollo/client` who aren't interested in using React won't be annoyed by missing `react` peer dependency warnings from npm.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
#5451 (comment)
This ensures it'll work without errors for Expo. Current RN (0.61) is on React 16.9.
Btw, why is it in
optionalDependenciesand notpeerDependencies? You might get 2 copies of react then, which causes super weird errors