Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset query store errors via ObservableQuery.resetQueryStoreErrors #4941

Merged
merged 4 commits into from
Jun 17, 2019
+56 −0
Merged

Reset query store errors via ObservableQuery.resetQueryStoreErrors #4941

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b02c37e
Reset query store errors via `ObservableQuery.resetQueryStoreErrors`
hwillson Jun 10, 2019
b99f657
Changelog update
hwillson Jun 10, 2019
ef12265
Remove unnecessary expect
hwillson Jun 17, 2019
50d4a61
Merge branch 'master' into hwillson/clear-query-store-errors
hwillson Jun 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unnecessary expect
@hwillson
hwillson committed Jun 17, 2019
commit ef122656fe052bf60d0422159545ce746a627d12
3 changes: 0 additions & 3 deletions packages/apollo-client/src/core/__tests__/ObservableQuery.ts
View file
Original file line number Diff line number Diff line change
@@ -2036,11 +2036,8 @@ describe('ObservableQuery', () => {
const { queryManager } = (observable as any);
const queryStore = queryManager.queryStore.get(observable.queryId);
queryStore.networkError = networkError;
expect(queryStore.networkError).toEqual(networkError);

observable.resetQueryStoreErrors();
expect(queryStore.networkError).toBeNull();

done();
}
});