Don't worry about empty tuple types in TupleToIntersection. #4502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although a zero-argument call to `mergeDeep` was always pretty pointless, it seemed worth handling that case for the sake of completeness. Well, apparently empty tuple types are forbidden by section 3.8.5 of the TypeScript spec, so (some versions of) the compiler complain about the `[]` in the `T extends []` case of `TupleToIntersection`: https://github.com/Microsoft/TypeScript/blob/master/doc/spec.md#385-tuple-type-literals Since we never really needed this case in the first place, the easy solution is to remove it. Note that the final cases in `TupleToIntersection` continue to cover the zero-argument case, for whatever it may be worth: T extends (infer U)[] ? U : any Should fix #4501.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although a zero-argument call to
mergeDeepwas always pretty pointless, it seemed worth handling that case for the sake of completeness.Well, apparently empty tuple types are forbidden by section 3.8.5 of the TypeScript spec, so (some versions of) the compiler complain about the
[]in theT extends []case ofTupleToIntersection.Since we never really needed this case in the first place, the easy solution is to remove it.
Note that the final cases in
TupleToIntersectioncontinue to cover the zero-argument case, for whatever it may be worth:Should fix #4501.