Prevent unhandled rejections by stopping QueryManager more thoroughly. #4359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The QueryManager#stop method cancels all pending fetches by running this.fetchQueryRejectFns. However, this leads to some unhandled promise rejections during tests, which might go unnoticed because they don't cause the test suite to fail. This commit makes the QueryManager#stop method a bit more aggressive about stopping active queries and unsubscribing from observables, which prevents the unhandled rejections.
benjamn
commented
Jan 22, 2019
| @@ -953,7 +963,12 @@ export class QueryManager<TStore> { | |||
| } | |||
|
|
|||
| public stopQuery(queryId: string) { | |||
| this.stopQueryInStore(queryId); | |||
| this.stopQueryNoBroadcast(queryId); | |||
| this.broadcastQueries(); | |||
There was a problem hiding this comment.
Reiterating #4337 (comment) here:
This now waits to call this.broadcastQueries() until after the query has been removed, whereas previously this.stopQueryInStore(queryId) would stop the query, call this.broadcastQueries(), then return control to stopQuery, which would finally call this.removeQuery(queryId).
It makes more sense to me to wait until the query has been removed to broadcast queries, but I'm not sure if this semantic subtlety was important before.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit was extracted from #4337, since the problem it solves seems unrelated to that PR.
The
QueryManager#stopmethod cancels all pending fetches by runningthis.fetchQueryRejectFns. However, this leads to some unhandled promise rejections during tests, which might go unnoticed because they don't cause the test suite to fail.This commit makes the
QueryManager#stopmethod a bit more aggressive about stopping active queries and unsubscribing from observables, which prevents the unhandled rejections.