You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to #3541, the ability to specify the type of variables is missing on watchQuery, query, mutate and subscribe methods in ApolloClient.
This PR adds optional generic type parameters to those methods that default to OperationVariables which seems to be used throughout the codebase.
Related to that, the parameters added in #3541 that were defaulted to any, now also use OperationVariables where it makes sense.
ERROR in /home/keyfu/dm-customerapp-ui/node_modules/apollo-client/ApolloClient.d.ts (108,27): Generic type 'Query' requires 1 type argument(s).
ERROR in /home/keyfu/dm-customerapp-ui/node_modules/apollo-client/ApolloClient.d.ts (120,30): Generic type 'Fragment' requires 1 type argument(s).
ERROR in /home/keyfu/dm-customerapp-ui/node_modules/apollo-client/ApolloClient.d.ts (126,25): Generic type 'WriteQueryOptions<TData, TVariables>' requires 2 type argument(s).
ERROR in /home/keyfu/dm-customerapp-ui/node_modules/apollo-client/ApolloClient.d.ts (138,28): Generic type 'WriteFragmentOptions<TData, TVariables>' requires 2 type argument(s).
ERROR in /home/keyfu/dm-customerapp-ui/node_modules/apollo-client/ApolloClient.d.ts (149,24): Generic type 'WriteDataOptions' requires 1 type argument(s).
ERROR in /home/keyfu/dm-customerapp-ui/node_modules/apollo-cache-inmemory/lib/inMemoryCache.d.ts (25,35): Generic type 'Query' requires 1 type argument(s).
ERROR in /home/keyfu/dm-customerapp-ui/node_modules/apollo-cache-inmemory/lib/inMemoryCache.d.ts (26,41): Generic type 'Fragment' requires 1 type argument(s).
ERROR in /home/keyfu/dm-customerapp-ui/node_modules/apollo-cache-inmemory/lib/inMemoryCache.d.ts (27,25): Generic type 'WriteQueryOptions<TData, TVariables>' requires 2 type argument(s).
ERROR in /home/keyfu/dm-customerapp-ui/node_modules/apollo-cache-inmemory/lib/inMemoryCache.d.ts (28,28): Generic type 'WriteFragmentOptions<TData, TVariables>' requires 2 type argument(s).
I'm using angular 4 and this is my package.json
"apollo-angular": "1.0.1",
"apollo-angular-link-http": "1.0.2",
"apollo-cache-inmemory": "1.1.10",
"apollo-client": "2.2.8",
"graphql": "^0.13.2",
"graphql-tag": "^2.8.0",
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #3541, the ability to specify the type of variables is missing on
watchQuery, query, mutate and subscribemethods inApolloClient.This PR adds optional generic type parameters to those methods that default to
OperationVariableswhich seems to be used throughout the codebase.Related to that, the parameters added in #3541 that were defaulted to
any, now also useOperationVariableswhere it makes sense.