Allow pre-configured cache to be given as config option to Apollo Boost Client #3561
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
This is related to #3220
New tests have been added
I've read through some discussions on this and I see that there are different opinions on the appropriateness of this kind of change and how it relates to your idea of the opinionated nature of ApolloBoost. Obviously, feel free to close the PR and disregard.
The challenge I'm running into, and which motivated this pull request, is that I have one small configuration change I need to make to the internal InMemoryCache configuration. That one small change is forcing me to drop ApolloBoost and instead configure everything manually.
It would be more user-friendly to be able to use ApolloBoost as is, but pass in specific dependency's when required while still retaining the rest of the defaults of ApolloBoost.
Anyhow, thanks for taking the time to read through this. I'll continue with my manual configuration for now. If this is a PR you're interested in moving forward with, let me know if there are any other changes you'd like to see implemented here. Otherwise, thanks for writing these great tools. 👋