Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt at fixing 170 race condition #1670

Merged
merged 2 commits into from
May 6, 2017
Merged

Attempt at fixing 170 race condition #1670

merged 2 commits into from
May 6, 2017

Conversation

helfer
Copy link
Contributor

@helfer helfer commented May 6, 2017

I was not able to make a failing test in Apollo Client, but this fixes the reproduction in react-apollo/#170, so I think it's worth releasing.

TODO:

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change
  • Add your name and email to the AUTHORS file (optional)
  • If this was a change that affects the external API, update the docs and post a link to the PR in the discussion

@helfer helfer merged commit 7ce2cff into master May 6, 2017
@helfer helfer deleted the hail-mary-170 branch May 6, 2017 19:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant