Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FragmentMatcher warning #1635

Merged
merged 5 commits into from
Apr 30, 2017
Merged

FragmentMatcher warning #1635

merged 5 commits into from
Apr 30, 2017

Conversation

helfer
Copy link
Contributor

@helfer helfer commented Apr 29, 2017

Print a warning when the heuristic fragment matcher is used on an interface or union fragment condition.

TODO:

  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change
  • Add your name and email to the AUTHORS file (optional)
  • If this was a change that affects the external API, update the docs and post a link to the PR in the discussion

@helfer helfer merged commit e85c39e into master Apr 30, 2017
@helfer helfer deleted the fm-usability branch April 30, 2017 21:00
field: selection,
context,
});
}
}
} else if (isInlineFragment(selection)) {
if (included) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this condition is never true. Can you confirm @helfer?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdebbar What makes you think that it's never true?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm.. I got confused with the nesting, I thought it was:

if (included) {
  ...
} else if (isInlineFragment(selection)) {
  if (included) {
    ...
  }
}

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants