add devtools suggestion to Apollo Client #1466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's roll with it :) |
stubailo
reviewed
Mar 22, 2017
| // First check if devtools is not installed | ||
| if (typeof (window as any).__APOLLO_DEVTOOLS_GLOBAL_HOOK__ === 'undefined') { | ||
| // Only for Chrome | ||
| if (navigator.userAgent.indexOf('Chrome') > -1) { |
There was a problem hiding this comment.
Is this actually a reliable way to detect chrome? Does anyone impersonate this string out of browsers we care about?
There was a problem hiding this comment.
Yeah, I think it's good enough. I don't think other clients impersonating Chrome matters in this case, because the main thing we want to do here is avoid printing it for innocent IE and Firefox users.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gotta catch em all!
(this prints a suggestion to install the devtools to the console of Chrome users during development)